Use console::measure_text_width to generate size_vec in select#104
Open
CircuitCoder wants to merge 1 commit intoconsole-rs:mainfrom
Open
Use console::measure_text_width to generate size_vec in select#104CircuitCoder wants to merge 1 commit intoconsole-rs:mainfrom
console::measure_text_width to generate size_vec in select#104CircuitCoder wants to merge 1 commit intoconsole-rs:mainfrom
Conversation
Collaborator
|
I would prefer if we integrate https://github.com/mgeisler/textwrap. That library is very high quality (I can attest to) and is being used in clap, and we personally don't need to maintain this text_width related logic. |
Author
|
OK I'll look into that when I have some time. Right now, the measured width is only used for clearing printed lines in select/sort/mult_select. If we switch to |
Collaborator
|
Yeah, we need to handle multi-lines text anyway normally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows using ANSI escape codes in select items.
Previously line width are measured using
str::len, which causes text with ANSI escape codes to be measured longer than they really are. Subsequently when clearing printed lines, additional lines can be cleared.