Remove dead code and 'Debug' trait bound on Input's 'interact_text*' methods#280
Merged
pksunkara merged 1 commit intoconsole-rs:masterfrom Sep 13, 2023
Merged
Remove dead code and 'Debug' trait bound on Input's 'interact_text*' methods#280pksunkara merged 1 commit intoconsole-rs:masterfrom
pksunkara merged 1 commit intoconsole-rs:masterfrom
Conversation
…ract_text*' methods
pksunkara
approved these changes
Sep 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #278 as requested.
The "term.features().is_attended()" check can never be reached because "term.is_term()" is checked at the beginning of the method (iiuc the checks are strictly equivalent).
Additionnally, the 'unwrap' call in the dead code forced a 'Debug' trait bound on the ::Err associated type.
Therefore i removed both the dead code and the now unnecessary trait bound.