Open
Conversation
Member
|
I only recently started helping out with dialoguer maintenance, so I'm unfamiliar with the subtleties of the API. I really haven't used dialoguer much at all, so pretty much I can only provide pretty passive maintenance to review/merge/publish obvious fixes/improvements. This does not seem like an obvious fix/improvement to me -- it imposes costs on all downstreams by internalizing an So I don't think I'm comfortable merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to create a path completion engine using the completion API, but found that it was very difficult because
Completion::get()was intended to be a stateless function, taking&self. I changed this to&mut Self, changing the interior type appropriately. Though this crate is not at 1.0 yet, if you wish not to make any breaking changes to the API, we can figure out a sort of backward-compatible solution. Let me know what you think.