Fix line length in Select when line has ASCII colors#347
Open
LandStander27 wants to merge 4 commits into
Open
Conversation
Member
|
There's API for this in the console crate which dialoguer already depends on -- would be better to reuse that. |
Author
|
Sorry, didn't see that. |
Member
|
Can you do a separate PR for resolving the clippy lints, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was trying to use
Select, but because I have ASCII color codes in my items, it was calculating the line length incorrectly, causing problems with rendering. For example, pressingUpwould move the entire selection prompt up as well, deleting the line above the prompt.So, I made a function
len_visible()on&strthat calculates the length, excluding the color codes.