Remove unnecessary spinner display in multi examples#682
Merged
djc merged 2 commits intoconsole-rs:mainfrom Jan 16, 2025
Merged
Remove unnecessary spinner display in multi examples#682djc merged 2 commits intoconsole-rs:mainfrom
djc merged 2 commits intoconsole-rs:mainfrom
Conversation
djc
approved these changes
Jan 15, 2025
Member
djc
left a comment
djc
left a comment
There was a problem hiding this comment.
I guess it was intentional in some way, but this change seems like an improvement to me.
@chris-laplante what do you think?
(It does look like there is a leftover warning you should fix.)
Collaborator
I agree it was probably intentional (perhaps to test whether spinners with |
Contributor
Author
Sorry about that - fixed the leftover warning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSIA