CP Delivereat #11
Open
CP Delivereat #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| } | ||
|
|
||
| fetch(){ |
Contributor
There was a problem hiding this comment.
I would give this method a more descriptive name. Fetch is a little too ambiguous
| if (this.props.basket[foodItem.id]) { | ||
| newBasket[foodItem.id] -= 1 | ||
| } else { | ||
| newBasket[foodItem.id] = 0 |
Contributor
There was a problem hiding this comment.
it might make sense to use delete the current item from basket here rather than set quantity to 0.
| } | ||
|
|
||
| this.props.setState({ basket: newBasket }, () => { | ||
| console.log(this.props.state); |
Contributor
There was a problem hiding this comment.
did you mean this.state.basket?
| class Menu extends React.Component { | ||
| constructor() { | ||
| super(); | ||
| this.state = {basket:{}} |
Contributor
There was a problem hiding this comment.
Basket state appears duplicated across Menu and Basket components. It would be better to store it on place such as App and share it using props
| }); | ||
|
|
||
| app.post('/api/order', function(req, res){ | ||
| const order = order(req.body); |
Contributor
There was a problem hiding this comment.
It looks like the order function does not exist so this is likely to break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.