David Gridley DeliverEat #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| addOrder(incomingOrder) { | ||
| let nextId; | ||
| const orderIds = Object.keys(order); | ||
| orderIds.length === 0 |
Contributor
There was a problem hiding this comment.
ternary returns a value so it would be better to use
const nextId = orderIds.length === 0 ? 1 : Math.max(...orderIds) + 1;
| constructor(){ | ||
| constructor() { | ||
| super(); | ||
| this.fetchMenu = this.fetchMenu.bind(this); |
Contributor
There was a problem hiding this comment.
fetch menu always gets called as a method and does not need binding
|
|
||
| render(){ | ||
| receivePageChange(id) { | ||
| if (id === "menu") { |
Contributor
There was a problem hiding this comment.
This could be shortened to
this.setState({
currentPage: id
});
| orderTotal: totalPrice | ||
| } | ||
| }, | ||
| () => localStorage.setItem("currentOrder", JSON.stringify(this.state.currentOrder)) |
Contributor
There was a problem hiding this comment.
The callback can be avoided here, passing incomingOrder to localStorage rather than waiting for setState to complete and inserting data into localStorage after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.