HL - DeliverEAT App #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (specificOrder) { | ||
| res.json(specificOrder); | ||
| } else { | ||
| res.status(404).json({ error: "Order not found" }); |
| } | ||
|
|
||
| getBasket(total) { | ||
| const deliveryCharge = total * 0.1; |
Contributor
There was a problem hiding this comment.
It would be slightly cleaner to implement this function as a separate child component and make this component simpler. Also, personal opinion` an if/else would be easier to read than multiline ternary
| @@ -0,0 +1,14 @@ | |||
| import React from "react"; | |||
|
|
|||
| class Footer extends React.Component { | |||
Contributor
There was a problem hiding this comment.
This could be a functional component
| @@ -0,0 +1,14 @@ | |||
| import React from "react"; | |||
|
|
|||
| class Header extends React.Component { | |||
Contributor
There was a problem hiding this comment.
This could be a functional component
| @@ -0,0 +1,44 @@ | |||
| import React from "react"; | |||
|
|
|||
| class Item extends React.Component { | |||
Contributor
There was a problem hiding this comment.
This could be a functional component
| import Item from "./Item"; | ||
| import Basket from "./Basket"; | ||
|
|
||
| class Menu extends React.Component { |
Contributor
There was a problem hiding this comment.
This could be a functional component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.