News update feature #11
Conversation
… stop horizontal overflow
| favouriteResults: [] | ||
| }) | ||
| //make sure we received an array in local storage before using array method to fill favouriteResults | ||
| faveList |
There was a problem hiding this comment.
Since we are not using the last part of the ternary, an if statement might be better here
|
|
||
|
|
||
|
|
||
| fetchSearchResults(searchString, page = 1){ |
|
|
||
| <h4>Recent News</h4> | ||
| {this.state.filmNews.map(story => { | ||
| return <NewsItem key={v4()} story={story} /> |
There was a problem hiding this comment.
The issue with using uuid here is that every time it is called, it will generate a new id number, which means that React will not be able to use the id to optimise render. Another way of doing it would be to generate a uuid for each news item when it comes back from API and then assign it to each news object. By re-using precomputed ids we can then allow React to map those ids to each component it renders
|
|
||
| handleSubmit(event){ | ||
| event.preventDefault() | ||
| this.props.retrieveSearchString(this.state.textInput) |
There was a problem hiding this comment.
It looks like there is some state duplication going on here since both HeaderSearch and App store the search string in their state. It would be better to store it just in state of App and pass it down as props to HeaderSearch
|
Good work! |
2 participants
No description provided.