React cinema #15
React cinema #15
Conversation
| render(){ | ||
| let check={fav_on:false}; | ||
|
|
||
| this.props.favList.find(movie => movie.imdbID==this.props.id)? check={fav_on:true}: |
There was a problem hiding this comment.
Ternary return a value. As a result it would better to rewrite above as const check=this.props.favList.find(movie => movie.imdbID==this.props.id)? {fav_on:true}:{fav_on:false}
There was a problem hiding this comment.
Better still, since we use check in cx, we can simplify above to const favOn=this.props.favList.find(movie => movie.imdbID==this.props.id); and then use it as
const classes=cx('material-icons md-24',{fav_on: favOn}); in cx
|
|
||
| receiveFavClick(id){ | ||
|
|
||
| if(this.state.favList.filter(movie => movie.imdbID==id).length == 0){ |
There was a problem hiding this comment.
It would be cleaner to calculate to generate a favList array in if/else, then you can set it in state and localStorage after and you would not need to duplicate code. Also, since favList would be precomputed we would not need to use a callback when setting it in localStorage
|
|
||
| receiveDeleteClick(id){ | ||
| this.setState({ | ||
| favList: this.state.favList.filter(movie => movie.imdbID !== id), |
There was a problem hiding this comment.
it would be better to create a favList array first then set it both in state and localStorage without using the callback
| } | ||
|
|
||
| render(){ | ||
| const storageString=localStorage.getItem('favList') |
There was a problem hiding this comment.
It would better to use favList from state rather than getting it from localStorage. favList in state should have same items.
|
Nice work. A few bits could be a slightly more concise or tidied up but very nice work overall |
2 participants
No description provided.