weekend react cinema #19
Conversation
| this.receiveVideoBlock = this.receiveVideoBlock.bind(this); | ||
| } | ||
|
|
||
| componentDidMount(){ |
There was a problem hiding this comment.
method is not in use and can be removed
|
|
||
| receivePaginationQuery(){ | ||
| this.setState({ | ||
| pageNumber: ++this.state.pageNumber |
There was a problem hiding this comment.
Calling ++ mutates state. It would be better to use this.state.pageNumber + 1 to increment value
| constructor(){ | ||
| super(); | ||
|
|
||
| this.state = { |
There was a problem hiding this comment.
it looks like this is not in use and can be removed
| }) | ||
| let searchEntry = event.target.value | ||
| if (searchEntry.length > 2){ | ||
| handleSubmit(event) |
There was a problem hiding this comment.
you are passing a change event into a submit event handler which might make things go funny. It would be better to split out functionality you want to share between two event handlers into own function and call that from both event handlers
| console.log(body) | ||
| this.setState({ | ||
| modalDetails: body, | ||
| modalClass: "modal2" |
There was a problem hiding this comment.
it would be better to make this property a boolean and set the actual class name in render method. the reason for that is that if you wanted to change the class name in future, you would need to do it in mutiple places. if you set the class name in render depending on the state of the boolean, you would only need to change it in one place
2 participants
No description provided.