responsive news reader #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
September 14, 2018 14:41
| .then(body => { | ||
| const topUsaNewsArticles = body.articles | ||
| return topUsaNewsArticles.map(article => { | ||
| topStoryDiv.innerHTML = ""; |
Contributor
There was a problem hiding this comment.
This might easier to generate using HTML strings
| .then(body => { | ||
| const topUsaNewsArticles = body.articles | ||
| return topUsaNewsArticles.map(article => { | ||
| topStoryDiv.innerHTML = ""; |
Contributor
There was a problem hiding this comment.
Also, it would be good to see display logic extracted out to own function so it could re-used later if needed
Contributor
|
Good work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Challenging project.... I need to work on callbacks