week3 responsive-news-reader #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrigrabov
reviewed
Jul 1, 2018
| return response.json(); | ||
| }) | ||
| .then(function(jsonData) { | ||
| window.scrollTo(0, 0); |
dmitrigrabov
reviewed
Jul 1, 2018
| } | ||
|
|
||
| function prevHandler(event){ | ||
| if(page<=1){ |
Contributor
There was a problem hiding this comment.
Good handling of edge case. Rather than using if/else I would return on the if to remove the need for an else.
if(page<=1){
alert("This is the first page");
return;
}
dmitrigrabov
reviewed
Jul 1, 2018
| return response.json(); | ||
| }) | ||
| .then(function(jsonData) { | ||
| window.scrollTo(0, 0); |
dmitrigrabov
reviewed
Jul 1, 2018
| .then(function(jsonData) { | ||
| showResults(jsonData); | ||
| searchBox.value=search; | ||
| prev.style.display="block"; |
Contributor
There was a problem hiding this comment.
it would be better to handle this using css classes rather than manipulating the style object
dmitrigrabov
reviewed
Jul 1, 2018
| @@ -0,0 +1,3 @@ | |||
| ab | |||
Contributor
There was a problem hiding this comment.
maybe add this to .gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.