Implement CRI ListPodSandboxMetrics

[akhilerm]

Implement the following CRI APIs

• ListPodSandboxMetrics
• ListMetricDescriptors

Fixes: #10506

TESTING

crictl metricsp command can be used to test the pod sandbox metrics returned by the runtime.

Output

Ref: https://gist.github.com/akhilerm/625d12b805d482cd577311be3a4f7551

Part of kubernetes/enhancements#2371

* **Pod Sandbox Metrics** ([#10691](https://github.com/containerd/containerd/pull/10691))
  
  Full implementation of Kubernetes CRI pod-level metrics API
  * **ListPodSandboxMetrics**: Query metrics for  running pods/sandboxes
  * **ListMetricsDescriptors**: Discover available metrics and their descriptions

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[akhilerm]

/cc @mikebrow

[zvonkok]

@akhilerm You still working on this?

[akhilerm]

@akhilerm You still working on this?

Yepp. I am working on it. Couldnt focus for sometime, but will pickup from next week onwards.

[zvonkok]

/cc @zvonkok

[k8s-ci-robot]

@zvonkok: GitHub didn't allow me to request PR reviews from the following users: zvonkok.

Note that only containerd members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @zvonkok

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[zvonkok]

@akhilerm Is this still on your roadmap?

[zvonkok]

AFAIC some metrics are missing if we want to be on par with cAdvisor.

[akhilerm]

@akhilerm Is this still on your roadmap?

Yes

AFAIC some metrics are missing if we want to be on par with cAdvisor.

The ListMetricDescriptors should have every metrics and this was added over from cadvisor. I will cross check if I missed something while adding from the cadvisor code.

[zvonkok]

@akhilerm I mostly referring to this table: https://github.com/google/cadvisor/blob/master/docs/storage/prometheus.md AFAIR the FS were missing?

[zvonkok]

This is the e2e test which metrics we will need: kubernetes/kubernetes#126213

[mikebrow]

LGTM

[dims]

LGTM

[akhilerm]

A few more additional metrics will be added as mentioned in kubernetes-sigs/cri-tools#1931 for the conformance

[mxpv]

@akhilerm could you pls create a follow up issue to address #10691 (comment)