Skip to content

[Tigron]: fix debug display issue with pty#4221

Merged
AkihiroSuda merged 1 commit intocontainerd:mainfrom
apostasie:2025-05-fix-tigron-display
May 8, 2025
Merged

[Tigron]: fix debug display issue with pty#4221
AkihiroSuda merged 1 commit intocontainerd:mainfrom
apostasie:2025-05-fix-tigron-display

Conversation

@apostasie
Copy link
Copy Markdown
Contributor

Fix #4220

Signed-off-by: apostasie <spam_blackhole@farcloser.world>
@apostasie
Copy link
Copy Markdown
Contributor Author

Carriage returns mess up the way we handle line breaks and length calculation, so, strip them out.

They are still available as-is for testing in stdout / stderr.
This is just impacting what we display under the command debugging information.

@apostasie apostasie marked this pull request as ready for review May 8, 2025 20:27
@apostasie
Copy link
Copy Markdown
Contributor Author

Docker failure is #4219

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v2.1.0 milestone May 8, 2025
@AkihiroSuda AkihiroSuda merged commit 57b251f into containerd:main May 8, 2025
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tigron]: pty debugging information display issue

2 participants