Add dev_id support for ImageFile #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigVan
reviewed
Dec 11, 2025
src/test/image_service_test.cpp
Outdated
|
|
||
| TEST_F(DevIDTest, parse_config_with_dev_id) { | ||
| std::string config_path, dev_id; | ||
| parse_config_and_dev_id("path/to/config.v1.json;dev123", config_path, dev_id); |
Member
There was a problem hiding this comment.
I think we only need a number without 'dev'
BigVan
reviewed
Dec 11, 2025
| if(find_image_file(dev_id) != nullptr) | ||
| LOG_ERROR_RETURN(0, -1, "dev id exists: `", dev_id); | ||
| photon::scoped_lock lock(m_image_files_mtx); | ||
| m_image_files[dev_id] = file; |
Member
There was a problem hiding this comment.
there is no need to set a scoped_lock here.
It's thread safe.
Signed-off-by: Xun Chen <[email protected]>
BigVan
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add dev_id support for ImageFile. A device can now carry an optional dev_id, which allows ImageService to
register, lookup, and manage ImageFile instances by a stable identifier.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Please check the following list: