Skip to content

spec,libcni: add metadata field to Interface struct for CNI Result#1051

Draft
MikeZappa87 wants to merge 2 commits intocontainernetworking:mainfrom
MikeZappa87:improvement/metadataoninterface
Draft

spec,libcni: add metadata field to Interface struct for CNI Result#1051
MikeZappa87 wants to merge 2 commits intocontainernetworking:mainfrom
MikeZappa87:improvement/metadataoninterface

Conversation

@MikeZappa87
Copy link
Copy Markdown
Contributor

@MikeZappa87 MikeZappa87 commented Dec 12, 2023

This PR resolves: #1050

This PR adds an optional 'metadata' field (map[string]string) to the Interfaces struct.

type Interface struct { 
    Name         string `json:"name"` 
    Mac          string `json:"mac,omitempty"` 
    Sandbox      string `json:"sandbox,omitempty"` 
    Metadata     map[string]string `json:"metadata,omitempty"` 
} 

@MikeZappa87 MikeZappa87 force-pushed the improvement/metadataoninterface branch from 8a84d87 to 9e58893 Compare December 13, 2023 00:01
@coveralls
Copy link
Copy Markdown

Coverage Status

coverage: 70.897%. remained the same
when pulling 6b248ea on MikeZappa87:improvement/metadataoninterface
into 2317778 on containernetworking:main.

@MikeZappa87 MikeZappa87 marked this pull request as ready for review December 13, 2023 03:44
@tamilmani1989
Copy link
Copy Markdown

@MikeZappa87 shall we mark this PR as draft until we close on #1050

@MikeZappa87 MikeZappa87 marked this pull request as draft January 8, 2024 18:20
Signed-off-by: Michael Zappa <michaelzappa@microsoft.com>
Signed-off-by: Michael Zappa <michaelzappa@microsoft.com>
@s1061123 s1061123 force-pushed the improvement/metadataoninterface branch from 6b248ea to 0d501e8 Compare March 11, 2024 17:22
@squeed squeed added this to the CNI v1.2 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal: Add metadata map field to Interface object in CNI Result

4 participants