libcni: skip GC plugin execution after config injection failure - #1184
Open
grey3228 wants to merge 1 commit into
Open
libcni: skip GC plugin execution after config injection failure#1184grey3228 wants to merge 1 commit into
grey3228 wants to merge 1 commit into
Conversation
GCNetworkList records errors returned by InjectConf, but still passes the returned pluginConfig to gcNetwork. InjectConf returns a nil PluginConfig on failure, so gcNetwork may panic when dereferencing net.Network.Type. Skip execution of that plugin after recording the configuration generation error. Also use pluginDescription when formatting plugin errors to avoid unnecessary dereferences while reporting failures. Found by Linux Verification Center (linuxtesting.org) with SVACE. Signed-off-by: Mikhail Dmitrichenko <m.dmitrichenko222@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes error handling in
GCNetworkList.When generating a GC plugin configuration fails,
GCNetworkListcurrently records the error but continues and callsgcNetwork(ctx, pluginConfig).InjectConfreturnsnilon failure, so this can lead to a nil pointer dereference insidegcNetwork.The proposed fix is to
continueafter recording the configuration generation error.Found by Linux Verification Center (linuxtesting.org) with SVACE.