pkg/types: tolerate nil entries in Result version converters - #1191
Open
thc1006 wants to merge 1 commit into
Open
pkg/types: tolerate nil entries in Result version converters#1191thc1006 wants to merge 1 commit into
thc1006 wants to merge 1 commit into
Conversation
A result with a JSON null element, for example an "ips" list that contains null, unmarshals to a slice holding a nil pointer. The 0.4.0 and 1.0.0 IP and interface converters, and the 0.2.0 downgrade loop, dereferenced that element with no nil check and panicked, while the sibling paths already go through the nil-safe Copy(). Guard the four converter helpers the way IPConfig.Copy and Interface.Copy do, and skip nil entries when downgrading to 0.2.0. Routes were already fine because they use the nil-safe Route.Copy(). The panic was reachable on ADD via GetAsVersion and on CHECK/DEL/GC when a cached result is re-read, so it could surface inside the runtime that called the plugin. Signed-off-by: thc1006 <84045975+thc1006@users.noreply.github.com>
thc1006
force-pushed
the
fix-nil-result-converters
branch
from
August 17, 2026 17:56
cfce860 to
bb01c09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A result with a JSON null element, for example an "ips" list that contains null, unmarshals to a slice holding a nil pointer. The 0.4.0 and 1.0.0 IP and interface converters, and the 0.2.0 downgrade loop, dereferenced that element with no nil check and panicked, while the sibling paths already go through the nil-safe Copy().
Guard the four converter helpers the way IPConfig.Copy and Interface.Copy do, and skip nil entries when downgrading to 0.2.0. Routes were already fine because they use the nil-safe Route.Copy(). The panic was reachable on ADD via GetAsVersion and on CHECK/DEL/GC when a cached result is re-read, so it could surface inside the runtime that called the plugin.