Skip to content

Add a link to project governance and MAINTAINERS file #6108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Apr 10, 2025
Merged

Add a link to project governance and MAINTAINERS file #6108

openshift-merge-bot merged 1 commit into from
Apr 10, 2025

Conversation

@mheon
Copy link
Member

@mheon mheon commented Apr 3, 2025

The MAINTAINERS file is based on the current OWNERS file. I added our core maintainers as they are expected to have commit bits on all project repositories.

The existing MAINTAINERS file, which appears out of date, was removed in favor of the new one (which has all CNCF mandated information).

What type of PR is this?

/kind other

What this PR does / why we need it:

Administrative work to link to the new governance model and add a CNCF-compliant maintainers list

How to verify it

N/A

Which issue(s) this PR fixes:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@nalind nalind added the No New Tests Allow PR to proceed without adding regression tests label Apr 3, 2025
nalind
nalind reviewed Apr 3, 2025
View reviewed changes
OWNERS Outdated
- mheon
- vrothberg
- Luap99
- mtrmac
Copy link
Member

@nalind nalind Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reviewers list supposed to include some, all, or none of the approvers list? Looking at podman's main branch, I see one approver who is not also a reviewer, so I don't know if there's a rule here
I think both lists were previously kept sorted.

@mheon
Copy link
Member Author

mheon commented Apr 3, 2025

@baude is the best source for that, but I think you need to be in both to get full privileges

Luap99
Luap99 reviewed Apr 7, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the Maintainer file error is also in the podman one so I did a PR there containers/podman#25820

MAINTAINERS.md Outdated
| Ashley Cui | [ashley-cui](https://github.com/ashley-cui) | Reviewer | [Red Hat](https://github.com/RedHatOfficial) |
| Nalin Dahyabhai | [nalind](https://github.com/nalind) | Core Maintainer | [Red Hat](https://github.com/RedHatOfficial) |
| Matthew Heon | [mheon](https://github.com/mheon) | Core Maintainer | [Red Hat](https://github.com/RedHatOfficial) |
| Paul Holzinger | [luap99](https://github.com/Luap99) | Core Maintainer | [Red Hat](https://github.com/RedHatOfficial) |
Copy link
Member

@Luap99 Luap99 Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: my github nick has a upper case L

MAINTAINERS.md Outdated
| Lokesh Mandvekar | [lsm5](https://github.com/lsm5) | Maintainer | [Red Hat](https://github.com/RedHatOfficial) |
| Urvashi Mohnani | [umohnani8](https://github.com/umohnani8) | Maintainer | [Red Hat](https://github.com/RedHatOfficial) |
| Aditya Rajan | [flouthoc](https://github.com/flouthoc) | Reviewer | [Red Hat](https://github.com/RedHatOfficial) |
| Jan Rodák | [honny1](https://github.com/Honny1) | Reviewer | [Red Hat](https://github.com/RedHatOfficial) |
Copy link
Member

@Luap99 Luap99 Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for Honny1

OWNERS Outdated
- mheon
- vrothberg
- Luap99
- mtrmac
Copy link
Member

@Luap99 Luap99 Apr 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if it matters but this is missing a final newline

@mheon mheon force-pushed the add_governance_and_owners branch from ee005ce to 9fb55df Compare April 9, 2025 13:09
@packit-as-a-service
Copy link

packit-as-a-service bot commented Apr 9, 2025

Ephemeral COPR build failed. @containers/packit-build please check.

nalind
nalind reviewed Apr 9, 2025
View reviewed changes
@mheon mheon force-pushed the add_governance_and_owners branch from 9fb55df to e13d0e3 Compare April 9, 2025 15:27
@nalind
Copy link
Member

nalind commented Apr 9, 2025

The MAINTAINERS.md and OWNERS don't currently agree on edsantiago and rhatdan. Perhaps https://gist.github.com/nalind/bc84b6a4aba8f6d2461a4ac36af9e478 or something similar will help.

@mheon mheon force-pushed the add_governance_and_owners branch from e13d0e3 to 4c5a664 Compare April 9, 2025 21:58
nalind
nalind approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@nalind nalind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@openshift-ci openshift-ci bot added the approved label Apr 9, 2025
Luap99
Luap99 approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon
Copy link
Member Author

mheon commented Apr 10, 2025

@baude @giuseppe PTAL

giuseppe
giuseppe approved these changes Apr 10, 2025
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, Luap99, mheon, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Add a link to project governance and MAINTAINERS file
53cd313 
The MAINTAINERS file is based on the current OWNERS file. I added
our core maintainers as they are expected to have commit bits on
all project repositories.

The existing MAINTAINERS file, which appears out of date, was
removed in favor of the new one (which has all CNCF mandated
information).

Signed-off-by: Matt Heon <[email protected]>
@mheon mheon force-pushed the add_governance_and_owners branch from 4c5a664 to 53cd313 Compare April 10, 2025 14:39
@baude
Copy link
Member

baude commented Apr 10, 2025

LGTM

@baude
Copy link
Member

baude commented Apr 10, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 10, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 2de361a into containers:main Apr 10, 2025
31 of 37 checks passed
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Jul 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@giuseppe giuseppe giuseppe approved these changes

@nalind nalind nalind approved these changes

@Luap99 Luap99 Luap99 approved these changes

Assignees

@baude baude

Labels

approved kind/other lgtm locked - please file new issue/PR No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mheon @nalind @baude @giuseppe @Luap99