stage_executor,getCreatedBy: expand buildArgs before invoking generatePathChecksum
#6110
Conversation
flouthoc
force-pushed
the
expand-mount-source
branch
2 times, most recently
from
b95ff6b to
3d926d3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
I don't understand enough about the buildah codebase but does that mean you are calling ProcessWord() twice on the that input. Supposedly it worked before the cache logic and now you add one new call for the cache. To me that seems to suggest we do that in two places which then means we might get a certain drift in behaviours?
Anyhow I don't understand enough about buildah so I am happy to shut up and say LGTM as it seems to fix the bug.
|
@flouthoc looks like this branch needs an update. |
|
One question, an updte needed, otherwise LGTM |
Patch in PR containers#5691 added a function to calculate and write checksum to history of `source` in `--mount` instructions but it did not add part to expand build args if they are present in `source` path. Following PR Just corrects the above issue and also adds a new test to make sure we don't break this in future again. Closes: containers/podman#25425 Signed-off-by: flouthoc <[email protected]>
flouthoc
force-pushed
the
expand-mount-source
branch
from
3d926d3 to
bc05858
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit 025e3e5
into
containers:main
Patch in PR #5691 added a function to calculate and write checksum to history of
sourcein--mountinstructions but it did not add part to expand build args if they are present insourcepath.Following PR Just corrects the above issue and also adds a new test to make sure we don't break this in future again.
Closes: containers/podman#25425
What type of PR is this?
What this PR does / why we need it:
How to verify it
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?