Modernize #6118
Merged
Modernize #6118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brought to you by
gofmt -r 'interface{} -> any' -w .
Signed-off-by: Kir Kolyshkin <[email protected]>
A slice returned by os.Environ is a already a brand new copy, no need to copy it again. Signed-off-by: Kir Kolyshkin <[email protected]>
Available since Go 1.22 (see https://tip.golang.org/ref/spec#For_range). Signed-off-by: Kir Kolyshkin <[email protected]>
openshift-ci
bot
added
do-not-merge/work-in-progress
kind/cleanup
|
Ephemeral COPR build failed. @containers/packit-build please check. |
nalind
reviewed
Apr 8, 2025
nalind
approved these changes
Apr 8, 2025
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
No functionality change, just code simplification. Covered by existing test (e.g. "run should also override /etc/hostname" in tests/run.bats). NO NEW TESTS NEEDED Signed-off-by: Kir Kolyshkin <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kolyshkin, Luap99, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Converts the code to use various Go 1.23+ features:
anyinstead ofinterface{}(available since Go 1.18);for rangeover integers (available since Go 1.22, https://tip.golang.org/ref/spec#For_range)slicesandmapsmethods more, where appropriate (Go 1.21...1.23)Please see individual commit for details.
Mostly found by modernize.
How to verify it
Existing tests should be adequate.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?