Revert "Move fuse-overlayfs to suggests" for Fedora 40 and older #2203
Conversation
Fedora completely ignores Suggests by default [1]. So, listing anything
as Suggests is as good as not mentioning it at all, unless it's intended
for tools and users who specifically respect it.
Downgrading the dependency on fuse-overlayfs to Suggests can make it go
missing from the user's system, and break old Toolbx containers [2].
This is a problem because when Fedora 40 was released, it included
containers-common-0.58.0-2.fc40 [3,4], which still had:
Recommends: fuse-overlayfs
Requires: (fuse-overlayfs if fedora-release-identity-server)
The change to Suggests in Fedora commit 447945e59a01cb67 ("Move
fuse-overlayfs to suggests") was made after that.
Such breaking changes are not meant for stable Fedora releases to avoid
surprising users, and are best done in the next upcoming version [5].
This is particularly true for atomic Fedora variants like Silverblue,
where the fuse-overlayfs RPM fell off the operating system image and had
to be reinstated [6]. It could also happen to those using other Fedora
variants, if, for example, they were trying to use a Kickstart for
installation.
This reverts Fedora commit 447945e59a01cb6715ed2a21877d45bf0b91ef67 for
Fedora 40 and older releases.
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/
[2] https://discussion.fedoraproject.org/t/rpm-ostree-update-breaks-toolbox-fedora-40
[3] See the f40 tag against containers-common-0.58.0-2.fc40:
https://koji.fedoraproject.org/koji/buildinfo?buildID=2423622
[4] The update with containers-common-0.58.0-2.fc40 was marked as stable
before Final Freeze started:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a267e93f8c
https://fedorapeople.org/groups/schedule/f-40/f-40-key-tasks.html
[5] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[6] workstation-ostree-config commit c7f72d2cd5eea6b1
https://pagure.io/workstation-ostree-config/c/c7f72d2cd5eea6b1
https://pagure.io/workstation-ostree-config/pull-request/526
Signed-off-by: Debarshi Ray <[email protected]>
|
Fedora 40 scratch build: Fedora 41 scratch build: Fedora Rawhide scratch build: |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
DNF is erroring out with: |
it's been fixed on centos, but mirror propagation may take a while. We can ignore that if need be. |
lsm5
left a comment
lsm5
left a comment
There was a problem hiding this comment.
LGTM. This can be gotten rid of after Fedora 40 goes EOL.
|
/packit rebuild-failed |
|
/lgtm |
|
Thanks for the review!
What was the problem? I am just curious. |
Looks like some metadata info went bad and got synced to all mirrors. |
|
/hold cancel @Luap99 could you please slash-approve this? |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: debarshiray, lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 8577f22
into
containers:main
3 participants
Fedora completely ignores
Suggestsby default [1]. So, listing anything asSuggestsis as good as not mentioning it at all, unless it's intended for tools and users who specifically respect it.Downgrading the dependency on
fuse-overlayfstoSuggestscan make it go missing from the user's system, and break old Toolbx containers [2].This is a problem because when Fedora 40 was released, it included
containers-common-0.58.0-2.fc40[3,4], which still had:The change to
Suggestsin Fedora commit 447945e59a01cb67 ("Move fuse-overlayfs to suggests") was made after that.Such breaking changes are not meant for stable Fedora releases to avoid surprising users, and are best done in the next upcoming version [5]. This is particularly true for atomic Fedora variants like Silverblue, where the
fuse-overlayfsRPM fell off the operating system image and had to be reinstated [6]. It could also happen to those using other Fedora variants, if, for example, they were trying to use a Kickstart for installation.This reverts Fedora commit 447945e59a01cb6715ed2a21877d45bf0b91ef67 for Fedora 40 and older releases.
[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/WeakDependencies/
[2] https://discussion.fedoraproject.org/t/rpm-ostree-update-breaks-toolbox-fedora-40
[3] See the
f40tag againstcontainers-common-0.58.0-2.fc40:https://koji.fedoraproject.org/koji/buildinfo?buildID=2423622
[4] The update with
containers-common-0.58.0-2.fc40was marked as stablebefore Final Freeze started:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-a267e93f8c
https://fedorapeople.org/groups/schedule/f-40/f-40-key-tasks.html
[5] https://docs.fedoraproject.org/en-US/fesco/Updates_Policy/
[6] workstation-ostree-config commit c7f72d2cd5eea6b1
https://pagure.io/workstation-ostree-config/c/c7f72d2cd5eea6b1
https://pagure.io/workstation-ostree-config/pull-request/526