Bump c/storage to v1.59.0, c/image to v5.36.0, c/common to v0.64.0, then v0.65.0-dev

[TomSweeneyRedHat]

Bump c/storage to v1.59.0 and c/image to v5.36.0. Then bump c/common to v0.64.0and then to the next dev version, v0.65.0-dev.

This is in preparation for Podman v5.6.0

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TomSweeneyRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [TomSweeneyRedHat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sourcery-ai]

The pull request #2476 has too many files changed.

We can only review pull requests with up to 300 changed files, and this pull request has 709.

[TomSweeneyRedHat]

I'm not complaining, just noting. This vendoring ripped out a number of indirects and probably over a hundred files

[Luap99]

linter is failing here for some reason, it looks like the kind of error where it fails to compile

[Luap99]

$ golangci-lint run
WARN [runner] Can't run linter goanalysis_metalinter: buildssa: failed to load package manifests: could not load export data: no export data for "github.com/containers/common/libimage/manifests" 
ERRO Running error: can't run linter goanalysis_metalinter
buildssa: failed to load package manifests: could not load export data: no export data for "github.com/containers/common/libimage/manifests" 

$ go build ./...
vendor/github.com/docker/docker/api/types/types.go:4:2: cannot find module providing package github.com/docker/docker/api/types/build: import lookup disabled by -mod=vendor
        (Go version in go.mod is at least 1.14 and vendor directory exists.)

Something is wrong with this vendor it seems, no idea what is going on.

If I run make vendor I get zero changes but both the go build and golangci-lint commands pass all of the sudden. So somehow it seems the go module metadata that it downloaded fixed it despite not having changes anything in the repo files which is rather concerning.

cc @mtrmac Not sure if you have seen something like this before?

[Luap99]

Ok so I can reproduce on a fresh system.

What is interesting is that deleting the repo and cloning it again triggers the same issue again so it must be some in repo files that trigger it. I narrowed it down to running go mod vendor which makes it work but it doesn't actually change any files whatsoever per git status so I am super confused what is going on.

What I did notice that moby removed the old //import comments in the package definition moby/moby@bf9d739 but still doesn't really make sense to me what it would fail if go mod vendor works fine

[Luap99]

Oh wait the issue is that gitignore ignores the build directory which is thus not part of the vendor commit, should have checked if the files exists earlier ...

[Luap99]

This needs #2478 first and then this must be rebased (and run make vendor again)

[mtrmac]

Thanks @Luap99 , @TomSweeneyRedHat .

LGTM after rebase.

[mtrmac]

LGTM.

validate/lint’s lint-extra step is failing with:

failed to fetch pull request patch: RequestError [HttpError]: Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead.: {"resource":"PullRequest","field":"diff","code":"too_large"} - https://docs.github.com/rest/pulls/pulls#list-pull-requests-files

[mtrmac]

Force-merged this, if I understand correctly, that failure should not affect future PRs.

I guess removing so much code that our CI can’t handle that should be celebrated :)

[TomSweeneyRedHat]

Doh! you beat me to the merge. I found 3 lint issues that should be tended to, I'll do them in a separate PR.

[Luap99]

Yeah these are from my debloat work in c/image. I did vendor into podman/buildah to make sure they still work without any issue and since I didn't find anything there I didn't consider trying to vendor them into c/common as I assumed that would be a trivial thing. Guess I was wrong, I will be more careful next time so we don't run into these vendor things on release day.