-
Notifications
You must be signed in to change notification settings - Fork 223
Move the repository to monorepo. #2520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR migrates the repository to a monorepo by updating the README with deprecation warnings and links, marking the Go module as deprecated, and adding a GitHub Actions workflow to auto-close incoming pull requests. Flow diagram for GitHub Action auto-closing PRsflowchart TD
PR[Pull Request Opened on main branch]
Action[GitHub Action: auto-close-prs.yml]
Close[Close PR]
Comment[Comment: 'This repository has been migrated...']
PR --> Action
Action --> Close
Action --> Comment
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
Blocking issues:
- An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)
General comments:
- Replace the non-standard [!WARNING] admonition in the README with a regular markdown blockquote or badge so the warning renders correctly on GitHub.
- Add a go.mod replace directive from github.com/containers/common to go.podman.io/common to ensure existing consumers seamlessly pick up the new monorepo module.
- Test the new auto-close GitHub Actions workflow in a non-critical branch to confirm it only targets PRs against main and doesn’t accidentally close valid migration pull requests.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Replace the non-standard [!WARNING] admonition in the README with a regular markdown blockquote or badge so the warning renders correctly on GitHub.
- Add a go.mod replace directive from github.com/containers/common to go.podman.io/common to ensure existing consumers seamlessly pick up the new monorepo module.
- Test the new auto-close GitHub Actions workflow in a non-critical branch to confirm it only targets PRs against main and doesn’t accidentally close valid migration pull requests.
## Security Issues
### Issue 1
<location> `.github/workflows/auto-close-prs.yml:13` </location>
<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.
*Source: opengrep*
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This commit: - mentions the monorepo in the README.MD. - deprecates the module in favor of go.podman.io/common. - adds github workflow to auto-close newly created PRs. Signed-off-by: Jan Kaluza <[email protected]>
|
/approve |
mtrmac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Luap99
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jankaluza, Luap99, mheon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit:
Warning
I only need a review. I will merge it myself tomorrow as part of the migration to monorepo.
Summary by Sourcery
Migrate the repository to the new monorepo by updating documentation, marking the module as deprecated, and auto-closing incoming PRs to redirect contributors to the new location.
Enhancements:
CI:
Documentation: