Skip to content

Conversation

@jankaluza
Copy link
Member

@jankaluza jankaluza commented Aug 25, 2025

This commit:

  • mentions the monorepo in the README.MD.
  • deprecates the module in favor of go.podman.io/common.
  • adds github workflow to auto-close newly created PRs.

Warning

I only need a review. I will merge it myself tomorrow as part of the migration to monorepo.

Summary by Sourcery

Migrate the repository to the new monorepo by updating documentation, marking the module as deprecated, and auto-closing incoming PRs to redirect contributors to the new location.

Enhancements:

  • Deprecate module in go.mod in favor of go.podman.io/common

CI:

  • Introduce GitHub Actions workflow to auto-close new PRs and guide contributors to the monorepo

Documentation:

  • Add warning and migration notice to README pointing to the monorepo and blog post

@sourcery-ai
Copy link

sourcery-ai bot commented Aug 25, 2025

Reviewer's Guide

This PR migrates the repository to a monorepo by updating the README with deprecation warnings and links, marking the Go module as deprecated, and adding a GitHub Actions workflow to auto-close incoming pull requests.

Flow diagram for GitHub Action auto-closing PRs

flowchart TD
    PR[Pull Request Opened on main branch]
    Action[GitHub Action: auto-close-prs.yml]
    Close[Close PR]
    Comment[Comment: 'This repository has been migrated...']
    PR --> Action
    Action --> Close
    Action --> Comment
Loading

File-Level Changes

Change Details Files
Add monorepo migration notice in project documentation
  • Introduce prominent warning block in README
  • Link to container-libs repository and migration blog post
README.md
Deprecate existing Go module in favor of shared common package
  • Insert deprecation comment at top of go.mod
go.mod
Implement GitHub Actions workflow to auto-close new PRs
  • Create workflow file under .github/workflows
  • Configure pull_request_target trigger on main branch
  • Use superbrothers/close-pull-request action with custom comment
.github/workflows/auto-close-prs.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot previously requested changes Aug 25, 2025
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

Blocking issues:

  • An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload. (link)

General comments:

  • Replace the non-standard [!WARNING] admonition in the README with a regular markdown blockquote or badge so the warning renders correctly on GitHub.
  • Add a go.mod replace directive from github.com/containers/common to go.podman.io/common to ensure existing consumers seamlessly pick up the new monorepo module.
  • Test the new auto-close GitHub Actions workflow in a non-critical branch to confirm it only targets PRs against main and doesn’t accidentally close valid migration pull requests.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Replace the non-standard [!WARNING] admonition in the README with a regular markdown blockquote or badge so the warning renders correctly on GitHub.
- Add a go.mod replace directive from github.com/containers/common to go.podman.io/common to ensure existing consumers seamlessly pick up the new monorepo module.
- Test the new auto-close GitHub Actions workflow in a non-critical branch to confirm it only targets PRs against main and doesn’t accidentally close valid migration pull requests.

## Security Issues

### Issue 1
<location> `.github/workflows/auto-close-prs.yml:13` </location>

<issue_to_address>
**security (yaml.github-actions.security.third-party-action-not-pinned-to-commit-sha):** An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps mitigate the risk of a bad actor adding a backdoor to the action's repository, as they would need to generate a SHA-1 collision for a valid Git object payload.

*Source: opengrep*
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

This commit:
- mentions the monorepo in the README.MD.
- deprecates the module in favor of go.podman.io/common.
- adds github workflow to auto-close newly created PRs.

Signed-off-by: Jan Kaluza <[email protected]>
@mheon
Copy link
Member

mheon commented Aug 25, 2025

/approve
LGTM on my end

Copy link
Contributor

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankaluza, Luap99, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7692941 into containers:main Aug 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants