Skip to content

Conversation

@giuseppe
Copy link
Member

the function is deprecated in gnulib

Closes: #442

@giuseppe
Copy link
Member Author

@flouthoc PTAL

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe force-pushed the update-hash-map-module branch from 6c78e60 to d5a7492 Compare April 29, 2025 21:34
@bhaible
Copy link

bhaible commented Apr 29, 2025

The title of this PR is wrong. It should be "use hash_remove instead of hash_delete". hash_delete is the old name, hash_remove the "new" name since 2021.

the function is deprecated in gnulib

Closes: containers#442

Signed-off-by: Giuseppe Scrivano <[email protected]>
@giuseppe giuseppe force-pushed the update-hash-map-module branch from d5a7492 to b88a093 Compare April 29, 2025 21:41
@giuseppe giuseppe changed the title main: use hash_delete instead of hash_remove main: use hash_remove instead of hash_delete Apr 29, 2025
@giuseppe
Copy link
Member Author

The title of this PR is wrong. It should be "use hash_remove instead of hash_delete". hash_delete is the old name, hash_remove the "new" name since 2021.

thanks for noticing, it was wrong in the commit message too. Fixed now

Copy link
Contributor

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit 28ba1fd into containers:main Apr 30, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gnulib changed: hash_delete -> hash_remove

3 participants