Skip to content

Fix clippy warnings #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2025
Merged

Fix clippy warnings #321

merged 1 commit into from
Apr 29, 2025

Conversation

tylerfanelli
Copy link
Member

No description provided.

@tylerfanelli
Fix clippy warnings
47db268 
Signed-off-by: Tyler Fanelli <[email protected]>
jakecorrenti
jakecorrenti approved these changes Apr 28, 2025
View reviewed changes
Copy link
Member

@jakecorrenti jakecorrenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

std::ptr::eq(ret, libc::MAP_FAILED) feels weird to use when comparing error codes, but I understand it's a bindings nuance.

@tylerfanelli
Copy link
Member Author

LGTM.

std::ptr::eq(ret, libc::MAP_FAILED) feels weird to use when comparing error codes, but I understand it's a bindings nuance.

I agree. The docs even say:

This is the same as using the == operator, but less generic

@tylerfanelli tylerfanelli merged commit 3722a25 into containers:main Apr 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakecorrenti jakecorrenti jakecorrenti approved these changes

@MatiasVara MatiasVara Awaiting requested review from MatiasVara MatiasVara is a code owner

@mtjhrc mtjhrc Awaiting requested review from mtjhrc mtjhrc is a code owner

@slp slp Awaiting requested review from slp slp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerfanelli @jakecorrenti