fix(Makefile): add libkrun.dylib symlink for EFI builds on macOS #492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix macOS EFI build: add libkrun.dylib symlink for pkg-config compatibility
Problem
When building libkrun on macOS with
EFI=1, the library is installed aslibkrun-efi.1.dylib, butlibkrun.pcreferences-lkrun. This causes linking failures for consumers using pkg-config:Affected consumers include
krun-sys(the Rust FFI bindings in this repo) and any other project usingpkg-config --libs libkrun.Solution
Add a
libkrun.dylibsymlink pointing tolibkrun-efi.1.dylibduring installation when building with EFI on Darwin. This aligns the installed library with whatlibkrun.pcdeclares.Changes
In the
install:target, after the EFI library is installed:Why this approach?
.pc.inorkrun-syslibkrun.so; macOS now has matchinglibkrun.dylib.pcfile already useslibkrunas the stable API nameTesting
After this fix: