Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored c/buildah to 32d78c69be17 #25756

Merged

Conversation

danegsta
Copy link
Contributor

@danegsta danegsta commented Apr 1, 2025

Updates buildah to 32d78c69be17205c27854371ca8eb7cce8fac1f4. This includes a fix required to support Windowed paths in podman cp.

Does this PR introduce a user-facing change?

None

@baude
Copy link
Member

baude commented Apr 1, 2025

@flouthoc @mheon wdyt ?

@flouthoc
Copy link
Collaborator

flouthoc commented Apr 1, 2025

Test build-with-timestamp-applies-to-oci-archive needs to skipped for remote

@flouthoc
Copy link
Collaborator

flouthoc commented Apr 1, 2025

I wonder why bud with ADD with git repository source is failing still when we already merged containers/buildah#6092

@danegsta I will check both of the failing tests.

@flouthoc
Copy link
Collaborator

flouthoc commented Apr 1, 2025

@danegsta Could you skip two tests by modifying this file https://github.com/containers/podman/blob/main/test/buildah-bud/apply-podman-deltas in a new commit

Tests to be skipped

  • bud with ADD with git repository source
  • build-with-timestamp-applies-to-oci-archive

I will unskip the first one in a followup PR.

@danegsta
Copy link
Contributor Author

danegsta commented Apr 1, 2025

@flouthoc yeah, I already started adding the entry for build-with-timestamp-applies-to-oci-archive locally.

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mheon
Copy link
Member

mheon commented Apr 1, 2025

LGTM

@mheon
Copy link
Member

mheon commented Apr 1, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
@danegsta
Copy link
Contributor Author

danegsta commented Apr 2, 2025

/assign tomsweeneyredhat

@mheon
Copy link
Member

mheon commented Apr 2, 2025

/approve

Copy link
Contributor

openshift-ci bot commented Apr 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danegsta, flouthoc, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 53be17d into containers:main Apr 2, 2025
83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants