Skip to content

Conversation

@mheon
Copy link
Member

@mheon mheon commented Aug 15, 2025

As the title says

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Matt Heon <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 15, 2025
@github-actions github-actions bot added the do-not-merge/wait-machine-os-build Indicates that a PR should not merge because it is waiting on machine OS images to build label Aug 15, 2025
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Building images at: containers/podman-machine-os#169

@packit-as-a-service
Copy link

Cockpit tests failed for commit da671ef. @martinpitt, @jelly, @mvollmer please check.

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, Luap99, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lsm5
Copy link
Member

lsm5 commented Aug 15, 2025

Ignore TMT test failures. f43 is waiting on a compose. Not sure about f42 cockpit issue, it did pass for rawhide though.

@ashley-cui
Copy link
Member

LGTM

@podmanbot podmanbot removed the do-not-merge/wait-machine-os-build Indicates that a PR should not merge because it is waiting on machine OS images to build label Aug 15, 2025
@Luap99
Copy link
Member

Luap99 commented Aug 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 56dc5f2 into containers:v5.6 Aug 15, 2025
86 of 90 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Nov 14, 2025
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants