-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Improve OOMKilled Visibility #27766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Improve OOMKilled Visibility #27766
Conversation
Signed-off-by: Bruce Fan <[email protected]>
Signed-off-by: Bruce Fan <[email protected]>
Signed-off-by: Bruce Fan <[email protected]>
Honny1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first glance, LGTM. I have some doubts due to the related test failure, but since it’s only one failure, I re-ran the test to see if it’s flaky or needs more attention.
Signed-off-by: Bruce Fan <[email protected]>
Signed-off-by: Bruce Fan <[email protected]>
b0c715a to
eb1f291
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
Signed-off-by: Bruce Fan <[email protected]>
As seen in issues #26701 and #25990, discovering whether a container has been OOMKilled doesn't seem to be very well known to users.
To address this, this PR adds an example of inspecting a container for the OOMKilled attribute to the podman inspect docs.
However, in scenarios where a container is automatically restarted, the podman inspect data will get wiped. In these cases, an OOMKilled attribute has been added to the container died event. This way, podman events can be a more persistent source of this information.
In short, this PR:
podman inspectto include an example of inspecting a container for the OOMKilled label.Fixes: #26701
Checklist
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?