Support multiple static IPs and validate subnets #27775
Draft
+354
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for multiple static IPs per container across single and multi-subnet networks. Document --network option for comma-separated IPs and subnet-based IP ordering. Fixes: https://issues.redhat.com/browse/RHEL-98277 Signed-off-by: Jan Rodák <[email protected]>
Signed-off-by: Jan Rodák <[email protected]>
Honny1
force-pushed
the
multiple-static-ips
branch
from
9a01a0a to
374b849
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
vikas-goel
reviewed
Dec 15, 2025
| { | ||
| name: "multiple static IPs in single subnet", | ||
| subnets: []string{"10.86.0.0/16"}, | ||
| staticIPs: []string{"10.86.0.10", "10.86.0.11", "10.86.0.12"}, |
Contributor
There was a problem hiding this comment.
Will be good to add a test case for IP address input in CIDR format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces comprehensive e2e tests for the multi-IP container feature, which allows users to assign multiple static IP addresses to a single container across single and multi-subnet networks.
Additionally, it refactors network inspection in e2e tests by introducing a reusable
InspectNetwork()helper function that eliminates duplicate code across the test suite. This helper replaces repetitive manual inspection + JSON unmarshaling patterns with a single, consistent interface.Fixes: https://issues.redhat.com/browse/RHEL-98277
Related: containers/netavark#1379
Related: containers/container-libs#557
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?