Skip to content

Conversation

@MayorFaj
Copy link
Contributor

@MayorFaj MayorFaj commented Dec 17, 2025

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Changes

  • Reversed the processing order in pkg/specgen/generate/kube/kube.go to process envFrom before env
  • Added integration test to verify correct precedence behavior

Does this PR introduce a user-facing change?

Fix `kube play` to follow Kubernetes precedence order where `env` values override `envFrom` values for the same environment variable

Fixes #27287

@MayorFaj MayorFaj marked this pull request as draft December 17, 2025 23:18
@MayorFaj MayorFaj marked this pull request as ready for review December 18, 2025 00:33
@MayorFaj MayorFaj force-pushed the fix-env-envfrom-precedence-27287 branch from 3596ec4 to f12f851 Compare December 18, 2025 00:54
@MayorFaj MayorFaj force-pushed the fix-env-envfrom-precedence-27287 branch from f12f851 to fa0bf62 Compare December 18, 2025 00:54
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@TomSweeneyRedHat
Copy link
Member

LGTM

@MayorFaj MayorFaj requested a review from Honny1 January 2, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kube play does not follow Kubernetes precedence order for env and envFrom

3 participants