Skip to content

Conversation

@kriansa
Copy link
Contributor

@kriansa kriansa commented Dec 28, 2025

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

Update documentation for podman-system.unit(5)

The documentation incorrectly stated that TimeoutStartSec "cannot be used" with Type=oneshot services. According to systemd.service(5), the startup timeout is simply disabled by default (set to infinity) for oneshot services, but TimeoutStartSec can still be explicitly configured if a timeout is desired.

@kriansa kriansa force-pushed the fix-timeoutstartsec-docs branch from aacff52 to 03fd89d Compare December 28, 2025 17:11
The documentation incorrectly stated that TimeoutStartSec "cannot be
used" with Type=oneshot services. According to systemd.service(5),
the startup timeout is simply disabled by default (set to infinity)
for oneshot services, but TimeoutStartSec can still be explicitly
configured if a timeout is desired.

Signed-off-by: Daniel Pereira <[email protected]>
@kriansa kriansa force-pushed the fix-timeoutstartsec-docs branch from 03fd89d to e6c3e4f Compare December 28, 2025 17:17
Copy link
Member

@baude baude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashley-cui
Copy link
Member

LGTM

@ashley-cui ashley-cui merged commit 73d6be2 into containers:main Jan 14, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants