refactor: extract shared TTY handling code into helper function #27871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shiavm006 <[email protected]>
Contributor
Author
|
hi @Luap99 This is a pure refactoring (extracting duplicated code) with no functional changes. Existing tests in Could you please add the "No New Tests" label? |
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Extracts duplicated TTY raw mode setup and cleanup code from
Attach()andExecStartAndAttach()into a sharedsetupTTYRawMode()helper function.Changes
setupTTYRawMode()helper function that encapsulates TTY setup logicAttach()to use the new helperExecStartAndAttach()to use the new helperWhy
This eliminates code duplication and improves maintainability. The TODO comment in
ExecStartAndAttach()indicated this refactoring was needed. This follows the same pattern used elsewhere in the codebase (e.g.,GetNoCompress()inpkg/machine/ocipull/ociartifact.go).Testing
pkg/bindings/test/attach_test.gowill run in CI