libpod: simplify unnecessary loops #27891
Open
+3
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a few spots in
libpodwhere loops are currently used for extracting keys from a map into a slice, or for checking the existence of a key in a map. These can simplified to remove the loop. There should be no change in behavior and I doubt that there would be performance differences; the intended improvement here is on readability.There are other similar changes that could be made, but the changes here are the most 'obvious'/agreeable of them.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable) (none)make validatepr(format/lint checks) - When running locally, failed to build Darwinpodman-machine- for libkrun,build constraints exclude all Go files in ..., pretty sure unrelatedNoneif no user-facing changes)Does this PR introduce a user-facing change?
None