Skip to content

Fix inconsistencies between --all and --filter=all in volume prune #28464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomSweeneyRedHat merged 1 commit into from
Apr 10, 2026
+19 −0
Merged

Fix inconsistencies between --all and --filter=all in volume prune #28464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cmd/podman/volumes/prune.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package volumes
import (
"bufio"
"context"
"errors"
"fmt"
"os"
"strings"
Expand Down Expand Up @@ -64,6 +65,11 @@ func prune(cmd *cobra.Command, _ []string) error {

// --all adds filter all=true (Docker-compatible; behavior is filter-only)
allFlag, _ := cmd.Flags().GetBool("all")
filterAllFlag := strings.EqualFold(pruneOptions.Filters.Get("all"), "true")
if allFlag && filterAllFlag {
return errors.New("--all and --filter all cannot be used together")
}
allFlag = allFlag || filterAllFlag
if allFlag {
pruneOptions.Filters.Set("all", "true")
}
Expand All @@ -79,6 +85,7 @@ func prune(cmd *cobra.Command, _ []string) error {
if err != nil {
return err
}
delete(listOptions.Filter, "all") // list does not support --filter all
filteredVolumes, err := registry.ContainerEngine().VolumeList(context.Background(), listOptions)
if err != nil {
return err
Expand Down
12 changes: 12 additions & 0 deletions test/e2e/volume_prune_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,14 @@ var _ = Describe("Podman volume prune", func() {
Expect(session.OutputToString()).To(ContainSubstring("named_vol"))
})

It("podman volume prune --all removes all unused volumes", func() {
podmanTest.PodmanExitCleanly("volume", "create", "prune_all_test")
podmanTest.PodmanExitCleanly("volume", "prune", "--all", "--force")

session := podmanTest.PodmanExitCleanly("volume", "ls")
Expect(session.OutputToStringArray()).To(HaveLen(1))
})

It("podman volume prune --filter all=true removes all unused volumes", func() {
podmanTest.PodmanExitCleanly("volume", "create", "prune_filter_all_test")
podmanTest.PodmanExitCleanly("volume", "prune", "--filter", "all=true", "--force")
Expand All @@ -50,6 +58,10 @@ var _ = Describe("Podman volume prune", func() {
Expect(session.OutputToStringArray()).To(HaveLen(1))
})

It("podman volume prune --filter all=true does not crash without --force", func() {
podmanTest.PodmanExitCleanly("volume", "prune", "--filter", "all=true")
})

It("podman prune volume --filter until", func() {
podmanTest.PodmanExitCleanly("volume", "create", "--label", "label1=value1", "myvol1")

Expand Down