Skip to content

ci: only install podman and crun for podman5 install task - #2453

Draft
olliewalsh wants to merge 2 commits into
containers:mainfrom
olliewalsh:ci_podman5
Draft

ci: only install podman and crun for podman5 install task#2453
olliewalsh wants to merge 2 commits into
containers:mainfrom
olliewalsh:ci_podman5

Conversation

@olliewalsh

@olliewalsh olliewalsh commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

apt-get upgrade was upgrading a number of unncessary packages. Switch to apt-get install instead.

Reduces the podman5 install step to ~40s. Previously this would take at least 3-4mins but in some cases could take up to 30mins.

Summary by Sourcery

Adjust CI workflows to avoid unnecessary package upgrades and explicitly manage Firefox removal and Podman installation.

CI:

  • Replace apt-get upgrade with apt-get install for Podman and crun to prevent upgrading unrelated packages in CI jobs.
  • Ensure Firefox is explicitly purged in relevant CI job steps before running package installations.
  • Remove Podman from generic package install steps, limiting Podman installation to the dedicated Podman 5 setup tasks.

apt-get upgrade was upgrading a number of unncessary packages.
Switch to apt-get install instead.

Signed-off-by: Oliver Walsh <owalsh@redhat.com>
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@sourcery-ai

sourcery-ai Bot commented Feb 23, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Update CI workflow to avoid unnecessary package upgrades by installing only required dependencies (including podman/crun) and consistently purging Firefox to free space before installs.

File-Level Changes

Change Details Files
Restrict package operations to installs of required tools and explicit Firefox purge, avoiding broad upgrades in CI jobs.
  • Replace generic apt-get install podman bash codespell steps with apt-get purge firefox followed by apt-get install bash codespell where podman is no longer needed in those jobs.
  • Change podman installation steps from apt-get upgrade -y podman crun to apt-get install -y podman crun to avoid upgrading unrelated packages.
  • Apply the same Firefox purge + targeted install pattern in the llama build job while keeping the larger dependency set for build tooling.
  • Ensure the lint/test setup job also purges Firefox and installs only bash and codespell without touching podman.
.github/workflows/ci.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@olliewalsh

Copy link
Copy Markdown
Collaborator Author

@mikebonnet PTAL

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding -y to the apt-get purge firefox commands (as you already do for some apt-get install calls) to avoid any chance of interactive prompts blocking CI jobs.
  • Since firefox is now purged in multiple jobs, you might factor this into a shared reusable step or composite action to keep the workflow DRY and make future changes to that behavior easier.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding `-y` to the `apt-get purge firefox` commands (as you already do for some `apt-get install` calls) to avoid any chance of interactive prompts blocking CI jobs.
- Since `firefox` is now purged in multiple jobs, you might factor this into a shared reusable step or composite action to keep the workflow DRY and make future changes to that behavior easier.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@olliewalsh
olliewalsh marked this pull request as draft February 24, 2026 09:51
@olliewalsh

Copy link
Copy Markdown
Collaborator Author

e2e CI is failing when trying to run a local registry. One of the other package upgrades appears to be significant but not obvious which/why. Setting the PR to draft for now...

@ieaves

ieaves commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

@olliewalsh It's not an issue with this PR. That test is failing everywhere. I was working on this yesterday but can't reproduce it locally. It seems like there's an issue with podman not finding the built imageid in the CI job.

@olliewalsh

Copy link
Copy Markdown
Collaborator Author

@olliewalsh It's not an issue with this PR. That test is failing everywhere. I was working on this yesterday but can't reproduce it locally. It seems like there's an issue with podman not finding the built imageid in the CI job.

It's passing on main, something about this change seems to be triggering the issue.
Github has issues yesterday though, probably what you were hitting.

@ieaves

ieaves commented Feb 24, 2026

Copy link
Copy Markdown
Collaborator

shrug I hit this exact test failure, with the exact same traceback (modulo the imageid) on two different PRs related to the inference spec ctx size yesterday. I'm skeptical three different PRs covering unrelated functional capabilities all triggered the exact same error in the exact same way but, who knows, maybe so.

@github-actions

Copy link
Copy Markdown

A friendly reminder that this PR had no activity for 30 days.

@rhatdan
rhatdan temporarily deployed to macos-installer March 27, 2026 09:33 — with GitHub Actions Inactive
@github-actions github-actions Bot removed the stale-pr label Mar 28, 2026
@github-actions

Copy link
Copy Markdown

A friendly reminder that this PR had no activity for 30 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants