Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/run: Add flag --no-tty/-T to run command. #587

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

likan999
Copy link
Contributor

@likan999 likan999 commented Oct 20, 2020

VSCode remote SSH extension needs to run commands inside toolbox without a TTY, otherwise it fails. With this patch, vscode can connect to toolbox in a remote host if you put RemoteCommand toolbox run -T bash in ssh config; it should work as well if using authorized_keys instead. The naming of -T option is borrowed from ssh -T.

@softwarefactory-project-zuul
Copy link

Build failed.

@softwarefactory-project-zuul
Copy link

Build failed.

@likan999 likan999 changed the title Add flag --notty to run command. cmd/run: Add flag --no-tty/-T to run command. Oct 29, 2020
@softwarefactory-project-zuul
Copy link

Build failed.

likan999 added a commit to likan999/ppa-toolbox that referenced this pull request Oct 30, 2020
Summary:
VSCode remote SSH extension needs to run commands inside toolbox without
a TTY, otherwise it fails. With this patch, vscode can connect to
toolbox in a remote host if you put `RemoteCommand toolbox run -T bash`
in ssh config; it should work as well if using `authorized_keys`
instead. The naming of `-T` option is borrowed from `ssh -T`.

containers#587
@softwarefactory-project-zuul
Copy link

Build failed.

likan999 added a commit to likan999/ppa-toolbox that referenced this pull request Oct 30, 2020
Summary:
VSCode remote SSH extension needs to run commands inside toolbox without
a TTY, otherwise it fails. With this patch, vscode can connect to
toolbox in a remote host if you put `RemoteCommand toolbox run -T bash`
in ssh config; it should work as well if using `authorized_keys`
instead. The naming of `-T` option is borrowed from `ssh -T`.

containers#587
likan999 added a commit to likan999/ppa-toolbox that referenced this pull request Oct 30, 2020
Summary:
VSCode remote SSH extension needs to run commands inside toolbox without
a TTY, otherwise it fails. With this patch, vscode can connect to
toolbox in a remote host if you put `RemoteCommand toolbox run -T bash`
in ssh config; it should work as well if using `authorized_keys`
instead. The naming of `-T` option is borrowed from `ssh -T`.

containers#587
@softwarefactory-project-zuul
Copy link

Build failed.

likan999 added a commit to likan999/ppa-toolbox that referenced this pull request Oct 30, 2020
Summary:
VSCode remote SSH extension needs to run commands inside toolbox without
a TTY, otherwise it fails. With this patch, vscode can connect to
toolbox in a remote host if you put `RemoteCommand toolbox run -T bash`
in ssh config; it should work as well if using `authorized_keys`
instead. The naming of `-T` option is borrowed from `ssh -T`.

containers#587
likan999 added a commit to likan999/ppa-toolbox that referenced this pull request Oct 30, 2020
Summary:
VSCode remote SSH extension needs to run commands inside toolbox without
a TTY, otherwise it fails. With this patch, vscode can connect to
toolbox in a remote host if you put `RemoteCommand toolbox run -T bash`
in ssh config; it should work as well if using `authorized_keys`
instead. The naming of `-T` option is borrowed from `ssh -T`.

containers#587
@softwarefactory-project-zuul
Copy link

Build failed.

likan999 added a commit to likan999/ppa-toolbox that referenced this pull request Oct 30, 2020
Summary:
VSCode remote SSH extension needs to run commands inside toolbox without
a TTY, otherwise it fails. With this patch, vscode can connect to
toolbox in a remote host if you put `RemoteCommand toolbox run -T bash`
in ssh config; it should work as well if using `authorized_keys`
instead. The naming of `-T` option is borrowed from `ssh -T`.

containers#587
@debarshiray debarshiray mentioned this pull request Oct 30, 2020
likan999 added a commit to likan999/ppa-toolbox that referenced this pull request Nov 4, 2020
Summary:
VSCode remote SSH extension needs to run commands inside toolbox without
a TTY, otherwise it fails. With this patch, vscode can connect to
toolbox in a remote host if you put `RemoteCommand toolbox run -T bash`
in ssh config; it should work as well if using `authorized_keys`
instead. The naming of `-T` option is borrowed from `ssh -T`.

containers#587
changwuf31 pushed a commit to changwuf31/toolbox that referenced this pull request Dec 29, 2020
Summary:
VSCode remote SSH extension needs to run commands inside toolbox without
a TTY, otherwise it fails. With this patch, vscode can connect to
toolbox in a remote host if you put `RemoteCommand toolbox run -T bash`
in ssh config; it should work as well if using `authorized_keys`
instead. The naming of `-T` option is borrowed from `ssh -T`.

containers#587
@softwarefactory-project-zuul
Copy link

Build failed.

@HarryMichal HarryMichal added 2. CLI Issue is related to the command line interface 2. Host Realm The issue is related to what happens on the host machine where Toolbox is executed 3. New Feature New feature 6. Minor Change Should not cause breakage labels Feb 26, 2021
@HarryMichal HarryMichal added the 6. Requires Toolbx Recreation This will take effect in new Toolbox containers and not in existing ones label Feb 26, 2021
@HarryMichal HarryMichal added this to the Release 0.2.0 milestone Feb 26, 2021
@HarryMichal HarryMichal removed the 6. Requires Toolbx Recreation This will take effect in new Toolbox containers and not in existing ones label Mar 10, 2021
Base automatically changed from master to main March 25, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. CLI Issue is related to the command line interface 2. Host Realm The issue is related to what happens on the host machine where Toolbox is executed 3. New Feature New feature 6. Minor Change Should not cause breakage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants