Add thread_id support for discord service #465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds optional ?= processing when constructing the discord URL and a new param thread_id
Contributor
Author
|
Is there anything i need to do?... |
|
Up on this. Would like to have this feature! |
Contributor
Author
Not sure theres much more I can do! |
piksel
requested changes
Dec 17, 2025
Member
There was a problem hiding this comment.
Hello! I have been away from github for too long. This seems like a great contribution!
The only thing I would suggest is using net/url.Values for the query string building and adding a test. I will make sure to follow up on this thread. Sorry for the delay!
…scord Co-Authored By: @piksel
Contributor
Author
|
Thank you! |
piksel
approved these changes
Dec 18, 2025
Contributor
Author
|
Thanks!! Gonna be glad to see this in downstream! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds optional ?= processing when constructing the discord URL and a new param thread_id
I gave it a quick test or two (with leaving the thread ID empty and without). Closes #464
Thank you!