Skip to content

Keep the Choices item visible to the form validation API#7

Merged
leofeyer merged 1 commit intocontao-components:mainfrom
zoglo:fix/choices-required
Aug 18, 2025
Merged

Keep the Choices item visible to the form validation API#7
leofeyer merged 1 commit intocontao-components:mainfrom
zoglo:fix/choices-required

Conversation

@zoglo
Copy link
Copy Markdown
Contributor

@zoglo zoglo commented Aug 15, 2025

Description

Hotfix for contao/contao#8687 till Choices-js/Choices#1332 might be implemented.

I commented out some CSS, unsure if it's wanted or not, it would highlight them:

image

@zoglo
Copy link
Copy Markdown
Contributor Author

zoglo commented Aug 17, 2025

@leofeyer whilst my PR in choices got merged: b70c9d2, it is not released yet and the bug itself is kinda misleading.

I'd argue for merging this as a hotfix as is and upgrading the CSS and JS once choices.js has been released in v11.2.

@leofeyer leofeyer changed the title Keep the choices item visible to the form validation API Keep the Choices item visible to the form validation API Aug 18, 2025
@leofeyer leofeyer merged commit d70d054 into contao-components:main Aug 18, 2025
@zoglo zoglo deleted the fix/choices-required branch August 18, 2025 08:00
zoglo added a commit to zoglo/contao-components-choices that referenced this pull request Nov 22, 2025
leofeyer added a commit that referenced this pull request Nov 26, 2025
Description
-----------

### Description

This PR updates the choices component to include the features of 11.2, fixing some bugs and activating additional features.

See https://github.com/Choices-js/Choices/blob/main/CHANGELOG.md#features

* fixes contao/contao#8687 and reverts #7
    
    <img width="596" height="573" alt="image" src="https://github.com/user-attachments/assets/c883fa7c-d49a-4be7-b870-0fb9d4729c38" />

* fixes contao/contao#8571 - choices not highlighting the selected value

    **Before**
    <img width="625" height="404" alt="image" src="https://github.com/user-attachments/assets/c83ee6fc-35e0-4397-b6c5-27e718fd73ed" />
    <img width="342" height="290" alt="image" src="https://github.com/user-attachments/assets/14066dcd-46da-4cf0-b34c-8c46d5f25076" />

    
    **After**
    <img width="594" height="479" alt="image" src="https://github.com/user-attachments/assets/b1640896-5498-4a8b-991c-14fa14e92d1a" />
    <img width="294" height="292" alt="image" src="https://github.com/user-attachments/assets/234341a4-6c8b-43bb-916d-4b0a7c75f7eb" />



* implements contao/contao#8696 - support for appendGroupInSearch

    <img width="581" height="367" alt="image" src="https://github.com/user-attachments/assets/0e685f2f-5105-491d-bb34-1eb003696a98" />

Commits
-------

1a2364f Update to 11.2.0 prerelease
d714aef Revert #7
8fab81a Revert CS
8ee9724 Rebuild Choices with a custom version number

Co-authored-by: leofeyer <1192057+leofeyer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants