Build: separate delete-snapshots from process-repos #1105
+84
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rverdile
reviewed
May 12, 2025
deployments/deployment.yaml
Outdated
| @@ -875,6 +875,87 @@ objects: | |||
| name: content-sources-candlepin | |||
| key: key | |||
| optional: true | |||
| - name: snapshot-cleanup | |||
| schedule: "0 1 * * *" | |||
There was a problem hiding this comment.
I think it would make sense to define a DAILY_CRON_JOB value for this, kinda like weekly
rverdile
reviewed
May 12, 2025
deployments/deployment.yaml
Outdated
Comment on lines
1143
to
1146
| description: whether to not run the daily job to delete outdated snapshots | ||
| required: false | ||
| value: "false" |
There was a problem hiding this comment.
this is unused, and looks like the new job is using SUSPEND_CRON_JOB instead. I'm guessing this can just be removed
There was a problem hiding this comment.
oops :) meant to update that value but yes just using the existing param is better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Separates the snapshot-cleanup job from process-repos so it can be run on its own schedule (this sets it to run daily). This may also help narrow down and reduce the errors being reported by glitchtip (https://issues.redhat.com/browse/HMS-5947)
Testing steps
UPDATE snapshots SET created_at = (NOW() - CAST('365 days' AS INTERVAL)) WHERE uuid = '<snapshot_uuid>';go run cmd/external-repos/main.go process-repos. You shouldn't see any delete-snapshots tasks enqueuedgo run cmd/external-repos/main.go snapshot-cleanup. This should start the delete-snapshots task