-
Notifications
You must be signed in to change notification settings - Fork 28
HMS-5508: Patternfly 5 - 6 update #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
e3e800e
to
4dbf32e
Compare
c1d9228
to
2bdf9e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been using this as my frontend to see if I notice any problems, and for the most part I don't. I've noticed only two things, but these could also just be issues with patternfly.
- The repositories and templates are kinda smushed on my screen. I can't see the column headers, the "18 hours ago" text needs to two lines, the status needs two lines.
Before:
- the "In progress" status text is kinda purple
Edit: added a before screenshot. And actually it was also an issue on patternfly 5, although it is a little worse now
pushed a fix to try to match the colors as much as possible to what we have currently, there were lots of pastels by default 😆 and adjusted the padding on the table, it's still not great but maybe not worse than it is in pf5? let me know how it's looking on your end |
Summary
Testing steps