Skip to content

HMS-5508: Patternfly 5 - 6 update #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Andrewgdewar
Copy link
Member

Summary

  • Updates Patternfly and associated packages to pf6
  • Touches a lot of files 😞

Testing steps

@jlsherrill
Copy link
Member

@Andrewgdewar Andrewgdewar force-pushed the HMS-5508 branch 4 times, most recently from e3e800e to 4dbf32e Compare April 29, 2025 20:56
@Andrewgdewar Andrewgdewar marked this pull request as ready for review May 1, 2025 16:59
@Andrewgdewar Andrewgdewar changed the title HMS-5508: Patternfly 5 - 6 update (WIP) HMS-5508: Patternfly 5 - 6 update May 1, 2025
@xbhouse xbhouse force-pushed the HMS-5508 branch 2 times, most recently from c1d9228 to 2bdf9e0 Compare May 7, 2025 17:03
Copy link
Contributor

@rverdile rverdile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using this as my frontend to see if I notice any problems, and for the most part I don't. I've noticed only two things, but these could also just be issues with patternfly.

  1. The repositories and templates are kinda smushed on my screen. I can't see the column headers, the "18 hours ago" text needs to two lines, the status needs two lines.
    Before:
    image

After:
image

  1. the "In progress" status text is kinda purple

Edit: added a before screenshot. And actually it was also an issue on patternfly 5, although it is a little worse now

@xbhouse
Copy link
Contributor

xbhouse commented May 15, 2025

I've been using this as my frontend to see if I notice any problems, and for the most part I don't. I've noticed only two things, but these could also just be issues with patternfly.

1. The repositories and templates are kinda smushed on my screen. I can't see the column headers, the "18 hours ago" text needs to two lines,  the status needs two lines.
   **Before:**
   ![image](https://private-user-images.githubusercontent.com/51457421/443735528-637b12ab-1c1c-469b-8726-dce637f4e730.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDczNDM1NzksIm5iZiI6MTc0NzM0MzI3OSwicGF0aCI6Ii81MTQ1NzQyMS80NDM3MzU1MjgtNjM3YjEyYWItMWMxYy00NjliLTg3MjYtZGNlNjM3ZjRlNzMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA1MTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNTE1VDIxMDc1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWE5MmMzZjIzYWQ3NjBmYmEyZGMzZmY4YzU1MDQwYTRkMWFmMTE3Zjk1OGM5MjU4M2U2OWY1YjIzZDRlODg3ZGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7oqiT0E0pxo6kJZGrjivrb1WZsb0uGFiddguwJBU8UE)

After: image

2. the "In progress" status text is kinda purple

Edit: added a before screenshot. And actually it was also an issue on patternfly 5, although it is a little worse now

pushed a fix to try to match the colors as much as possible to what we have currently, there were lots of pastels by default 😆

and adjusted the padding on the table, it's still not great but maybe not worse than it is in pf5? let me know how it's looking on your end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants