-
Notifications
You must be signed in to change notification settings - Fork 122
fix: Apply same restrictions on ingredient deltas as active manifest for validation state #1624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
gpeacock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our logic has always been that if an ingredient was added as part of a signed manifest, the signer is accepting the ingredient as it was at the time it was signed. So an untrusted ingredient can exist inside a trusted manifest, just as an unsigned ingredient can be added or, an ingredient that has some other set of errors.
But: if the status of that ingredient has changed since it was signed, either through tampering or the signature no longer being valid due to OSCP or other issues, that should be caught as delta here and reported as such.
|
@gpeacock So instead of checking if the ingredient delta has, for example, |
|
I came to the conclusion that we really only need to loosen the |
This PR changes our logic to apply the same conditions we do on the active manifest to the ingredients as well. If you have an untrusted ingredient, should you have a trusted active manifest? If the ingredient has an untrusted claim signature does it already affect the active manifests success codes?
This change breaks many of our test cases that do not report a trusted success code (and others) for ingredients. I'm opening this PR for further discussion on this topic.