Auto Internal Name: Filtering fields to show only short texts + refactor [MAPS-95] #10260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apps/auto-internal-name/src/components/OverrideRow.tsx # apps/auto-internal-name/src/locations/ConfigScreen.tsx # apps/auto-internal-name/test/components/OverrideRow.spec.tsx # apps/auto-internal-name/test/locations/ConfigScreen.spec.tsx # apps/auto-internal-name/test/mocks/mockSdk.ts
FBanfi
force-pushed
the
auto-internal-maps-95
branch
from
33f26ca to
4b220b6
Compare
# Conflicts: # apps/auto-internal-name/eslint.config.mts # apps/auto-internal-name/src/components/OverrideRow.tsx # apps/auto-internal-name/src/locations/ConfigScreen.tsx # apps/auto-internal-name/src/utils/types.ts # apps/auto-internal-name/test/components/OverrideRow.spec.tsx # apps/auto-internal-name/test/locations/ConfigScreen.spec.tsx # apps/auto-internal-name/test/mocks/mockSdk.ts
JuliRossi
reviewed
Nov 20, 2025
Collaborator
JuliRossi
left a comment
JuliRossi
left a comment
There was a problem hiding this comment.
⭐ Good on taking this refactor. Just left a few comments
| 'react/jsx-uses-react': 'off', | ||
| 'react/react-in-jsx-scope': 'off', | ||
| 'no-unused-vars': 'off', | ||
| 'react/prop-types': 'off', |
Collaborator
There was a problem hiding this comment.
❓ Why are we removing this restriction ?
Collaborator
Author
There was a problem hiding this comment.
Oh yeah, that was because eslint wasn't letting me to infer the prop types, but I specified them and added the restriction again. ✅ Nice catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The app works for short text fields only, so the single line editor is rendered in the Field location.
If source field id selected in the config screen is not from a short text, the value couldn’t be displayed correctly. The same happens when we add an override, so we should add this check/filter there too.
In addition, in this PR a pending refactor to extract a new component which handles all the actions for the overrides was added. Actions such as:
Approach
Filter the sourceFieldId and fieldName autocompletes to show only short text fields.
Testing steps
Added automated tests. Manual test:
Grabacion.de.pantalla.2025-11-18.a.la.s.12.14.47.p.m.mov
Breaking Changes
N/A
Dependencies and/or References
Link to MAPS-95
Deployment
N/A