Bulk Edit: render default editor if field uses custom appereance [MAPS-97] #10268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| const ERROR_MESSAGE = 'Failed to initialize field editor. Please try again.'; | ||
| const SUPPORTED_WIDGET_IDS = [ |
Contributor
There was a problem hiding this comment.
Small suggestion: Make this a map/hashmap data structure instead of an array to make the lookup efficient on line 147
Collaborator
Author
There was a problem hiding this comment.
Good catch, I've changed it to use a Set so the lookup is faster
Contributor
ryunsong-contentful
left a comment
ryunsong-contentful
left a comment
There was a problem hiding this comment.
Overall looks good, let me know what you think of the small fix and I can approve afterwards
| }, [field, value, onChange, locale]); | ||
|
|
||
| const getWidgetId = (field: ContentTypeField) => { | ||
| const fieldTypeToDefaultWidget: Record<string, string> = { |
Contributor
There was a problem hiding this comment.
Is there a reason why this isn't a constant outside of the component so that this data doesn't rerender?
Collaborator
Author
There was a problem hiding this comment.
Not really, I've moved it
ryunsong-contentful
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The app currently displays an error message if a field uses a custom appearance.
Approach
We are not able to render the custom appearance but we can still render the default field editor for the underlying field type.
Before
Screen.Recording.2025-11-20.at.11.22.51.mov
After
Screen.Recording.2025-11-20.at.11.33.11.mov