Localization for auto internal name [MAPS-117] #10269
Open
+40
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaquincasal
approved these changes
Nov 20, 2025
Collaborator
joaquincasal
left a comment
joaquincasal
left a comment
There was a problem hiding this comment.
Code looks good!
My only question is if it makes sense to use the content from the default locale in case a field doesn't have content for a specific locale. The other option would be to leave that specific locale empty
FBanfi
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adding localization handling for auto internal name
Approach
Testing steps
Grabacion.de.pantalla.2025-11-20.a.la.s.2.33.03.p.m.mov
Grabacion.de.pantalla.2025-11-20.a.la.s.2.32.05.p.m.mov