-
Notifications
You must be signed in to change notification settings - Fork 166
feat: Add feature selection capability to Bedrock Content Generator [] #10276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add enabledFeatures parameter to installation configuration - Create FeatureSelectionSection component for config page - Filter sidebar buttons to show only enabled features - Add validation in Dialog to prevent access to disabled features - Ensure backward compatibility (defaults to all features if not configured)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds feature selection capability to the Bedrock Content Generator app, allowing administrators to configure which AI features are available to users. The implementation ensures backward compatibility by defaulting to all features when not configured.
Key Changes
- Added
enabledFeaturesparameter to installation configuration with validation - Created UI component for feature selection in the configuration page
- Implemented feature filtering in sidebar and dialog locations
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
appInstallationParameters.ts |
Added optional enabledFeatures field to installation parameters |
parameterReducer.ts |
Added reducer action and logic for updating enabled features |
FeatureSelectionSection.tsx |
New component providing checkbox UI for feature selection |
configText.ts |
Added text constants for feature selection section |
ConfigPage.tsx |
Integrated feature selection section into config page |
useSidebarParameters.ts |
Added logic to retrieve and default enabled features |
SidebarButtons.tsx |
Updated to filter buttons based on enabled features |
Dialog.tsx |
Added validation to prevent access to disabled features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ontent-generator/src/components/config/feature-selection-section/FeatureSelectionSection.tsx
Show resolved
Hide resolved
apps/bedrock-content-generator/src/components/config/parameterReducer.ts
Show resolved
Hide resolved
sam-is-content
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works well!
| * This hook is used to get the installation parameters from the sidebar location, | ||
| * checks to see if there is a brand profile, validates the API Key and returns any errors | ||
| * | ||
| * @returns {hasBrandProfile, apiError} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so this hook didn't actually return an apiError to begin with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah i guess not. looking at it, it's pretty clear. I removed this to get rid of a lint warning
Requested here https://contentful.slack.com/archives/C07T0NJ3D98/p1763716062687039
Change summary