fixes repositoryId issue and adds selection type of single or multiple - #11261
Open
Mike Reynolds (MikeDReynolds68) wants to merge 2 commits into
Open
fixes repositoryId issue and adds selection type of single or multiple#11261Mike Reynolds (MikeDReynolds68) wants to merge 2 commits into
Mike Reynolds (MikeDReynolds68) wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This update adds following capabilities:
repositoryIdproperty was missing from the Adobe Content Advisor config properties and has been added so it can be used for restricting user access to a single repositoryselectedAssetsproperty has been added to the Content Advisor config properties to persist previously selected assets and uses the asset ids from the current field value if theprefillSelectedAssetsconfig value is 'Yes'CustomUpdateStateValueFnhas been added to modify the save functionality so the app replaces the existing field values with the new selections if theprefillSelectedAssetsconfig value is 'Yes' and adds the new selections to the previously selected assets if the value is 'No'prefillSelectedAssetsconfig has been added to support theselectedAssetsproperty in the Content Advisor props and theCustomUpdateStateValueFnselectionTypeproperty has been added to the Content Advisor props to support the creation of asset fields that contain a 'single' asset or 'multiple' assets (the selectionType property is populated from the value of a new instance config property of the same name with the following options: single, multipleaemTierTypeconfig property has been changed from text to a dropdown to prevent invalid values and contains the following options: delivery, authorenvconfig property has been changed from text to a dropdown to prevent invalid values and contains the following options: prod, stageApproach
The changes were made in accordance with the capabilities provided by the
contentful/dam-app-basepackage, the Adobe Content Advisor front-end-as-a-service app, and best practices for installation and instance config properties.Testing steps
The following tests should be passed:
repositoryIdin the application's installation config restricts users to the identified repository and no othersrepositoryIdin the application's installation config allows users to see all repositories available to them based on their AEM Assets permissionsprefillSelectedAssetsto 'Yes' selects all previously selected assets when opening the Adobe Content Advisor modalprefillSelectedAssetsto 'Yes' causes the previously selected assets to be replaced with the assets selected in the Adobe Content Advisor modalprefillSelectedAssetsto 'No' leaves the previously selected assets unselected when opening the Adobe Content Advisor modalprefillSelectedAssetsto 'No' cause the assets selected in the Adobe Content Advisor modal to be added to the previously selected assetsselectionTypeto 'single' restricts the user to the selection of a single asset in the Adobe Content Advisor modalselectionTypeto 'multiple' allows the user to select multiple assets in the Adobe Content Advisor modalaemTierTypeto 'delivery' or 'stage' restricts the user to repositories of the selected typeenvto 'prod' or 'stage' restricts the user to repositories in the selected environmentBreaking Changes
None
Dependencies and/or References
All changes are based on information collected in zoom calls, email or slack
Deployment
None that I am aware of