Creating an NA <-> EU migration option #3005
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Chaffexd
changed the title
lib/cmds/migrate_cmds/datacenter.js
Outdated
|
|
||
| if (argv.includeTaxonomies) { | ||
| if (!argv.sourceOrgId || !argv.targetOrgId) { | ||
| throw new Error( |
There was a problem hiding this comment.
Optional suggestion, you can use yargs implies instead of manually validating/throwing.
lib/cmds/migrate_cmds/datacenter.js
Outdated
| await organizationExport({ | ||
| context: { managementToken: argv.sourceToken }, | ||
| organizationId: argv.sourceOrgId, | ||
| header: argv.header, |
There was a problem hiding this comment.
header needs to be a defined property in the yargs right?
There was a problem hiding this comment.
after review, its actually deadweight so I'm removing it
lib/cmds/migrate_cmds/datacenter.js
Outdated
| `${emojic.inboxTray} Importing taxonomies into target organization ${argv.targetOrgId}...` | ||
| ) | ||
|
|
||
| const { |
There was a problem hiding this comment.
question, is there a benefit to requiring inline here?
There was a problem hiding this comment.
at the time of writing, I just put them there but moving them to be globally available seems unnecessary
|
Hello @Chaffexd, thanks a bunch for investing the time to improve this tool. I left a couple non-blocking questions/suggestions but otherwise the code looks very clean and well tested. After discussing with the Developer Experience PM, we have a couple thoughts around the name of the command
Let us know what you think! Lastly, this PR would really benefit from having a dedicated doc for the new command, similar to other commands have readme with basic descriptions/options/limitations. |
…ry logic and update unit tests
There was a problem hiding this comment.
this file and the tmp_export directory should be reverted.
I've spent some time adding functionality to allow bi-directional space transfer(s) between NA and EU data centers as this functionality doesn't currently exist.
How it works:
contentful migrate datacenter --help ✔ at 18:35:19
migrate datacenter
Migrate a space between Contentful data centers
Options:
-h, --help Show help [boolean]
--source Source data center (na or eu)
[required] [choices: "na", "eu"]
--target Target data center (na or eu)
[required] [choices: "na", "eu"]
--source-space-id Source space ID [string] [required]
--target-space-id Target space ID [string] [required]
--environment-id Environment ID (e.g. master)
[string] [default: "master"]
--source-token Source CMA token [string] [required]
--target-token Target CMA token [string] [required]
--use-verbose-renderer Display progress in new lines instead of spinner
[boolean] [default: false]
--include-taxonomies Migrate taxonomies (Concepts & Concept Schemes)
before importing content [boolean] [default: false]
--source-org-id Organization ID where taxonomies should be exported
from [string]
--target-org-id Organization ID where taxonomies should be imported
to [string]
--skip-content-publishing Skips content publishing. Creates content but does
not publish it [boolean] [default: false]
An example:
contentful migrate datacenter
--source na
--target eu
--source-space-id
--target-space-id
--source-token
--target-token
--source-org-id
--target-org-id
--include-taxonomies
--skip-content-publishing
I have manually tested this and it works both ways, it allows you to include taxonomies if you use them as otherwise the space import will fail, if you don't use them then you can simple use --include-taxonomies false